Extern/Beef
1
0
Fork 0
mirror of https://github.com/beefytech/Beef.git synced 2025-06-10 20:42:21 +02:00
Code Activity

Fixed switch with constant value and fallthroughs

Browse source
This commit is contained in:
Brian Fiete 2020-11-04 09:23:34 -08:00
parent e1119d77a9
commit d4d74ed37c
2 changed files with 32 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

42
IDEHelper/Backend/BeMCContext.cpp
View file

@ -3744,7 +3744,7 @@ BeMCOperand BeMCContext::AllocVirtualReg(BeType* type, int refCount, bool mustBe
if (mDebugging)
{
if (mcOperand.mVRegIdx == 14)
if (mcOperand.mVRegIdx == 6)
{
NOP;
}
@ -8611,23 +8611,35 @@ void BeMCContext::DoActualization()
if (vregInfo->mIsExpr)
{
// Create a new reg with the expression, and then load the value into the old non-expressionized reg
// This has the advantage of fixing any other references to this expr, too
auto scratchReg = AllocVirtualReg(vregInfo->mType, 2, false);
auto scratchVRegInfo = mVRegInfo[scratchReg.mVRegIdx];
if (vregInfo->IsDirectRelToAny())
{
AllocInst(BeMCInstKind_Mov, BeMCOperand::FromVReg(vregIdx), vregInfo->mRelTo, instIdx++ + 1);
scratchVRegInfo->mIsExpr = true;
scratchVRegInfo->mRelTo = vregInfo->mRelTo;
scratchVRegInfo->mRelOffset = vregInfo->mRelOffset;
scratchVRegInfo->mRelOffsetScale = vregInfo->mRelOffsetScale;
vregInfo->mIsExpr = false;
vregInfo->mRelTo = BeMCOperand();
vregInfo->mRelOffset = BeMCOperand();
vregInfo->mRelOffsetScale = 1;
}
else
{
// Create a new reg with the expression, and then load the value into the old non-expressionized reg
// This has the advantage of fixing any other references to this expr, too
auto scratchReg = AllocVirtualReg(vregInfo->mType, 2, false);
auto scratchVRegInfo = mVRegInfo[scratchReg.mVRegIdx];
vregInfo->mIsExpr = false;
vregInfo->mRelTo = BeMCOperand();
vregInfo->mRelOffset = BeMCOperand();
vregInfo->mRelOffsetScale = 1;
scratchVRegInfo->mIsExpr = true;
scratchVRegInfo->mRelTo = vregInfo->mRelTo;
scratchVRegInfo->mRelOffset = vregInfo->mRelOffset;
scratchVRegInfo->mRelOffsetScale = vregInfo->mRelOffsetScale;
CreateDefineVReg(scratchReg, instIdx++ + 1);
AllocInst(BeMCInstKind_Mov, BeMCOperand::FromVReg(vregIdx), scratchReg, instIdx++ + 1);
vregInfo->mIsExpr = false;
vregInfo->mRelTo = BeMCOperand();
vregInfo->mRelOffset = BeMCOperand();
vregInfo->mRelOffsetScale = 1;
CreateDefineVReg(scratchReg, instIdx++ + 1);
AllocInst(BeMCInstKind_Mov, BeMCOperand::FromVReg(vregIdx), scratchReg, instIdx++ + 1);
}
}
}
}

6
IDEHelper/Compiler/BfStmtEvaluator.cpp
View file

@ -4311,6 +4311,8 @@ void BfModule::Visit(BfSwitchStatement* switchStmt)
auto startingLocalVarId = mCurMethodState->GetRootMethodState()->mCurLocalVarId;
bool prevHadFallthrough = false;
Dictionary<int64, _CaseState> handledCases;
for (BfSwitchCase* switchCase : switchStmt->mSwitchCases)
{
@ -4596,7 +4598,7 @@ void BfModule::Visit(BfSwitchStatement* switchStmt)
auto prevInsertBlock = mBfIRBuilder->GetInsertBlock();
SetAndRestoreValue<bool> prevIgnoreWrites(mBfIRBuilder->mIgnoreWrites, true, !mayHaveMatch);
SetAndRestoreValue<bool> prevIgnoreWrites(mBfIRBuilder->mIgnoreWrites, true, !mayHaveMatch && !prevHadFallthrough);
mBfIRBuilder->AddBlock(caseBlock);
mBfIRBuilder->SetInsertPoint(caseBlock);
@ -4677,6 +4679,8 @@ void BfModule::Visit(BfSwitchStatement* switchStmt)
prevIgnoreWrites.Restore();
mBfIRBuilder->SetInsertPoint(prevInsertBlock);
prevHadFallthrough = mCurMethodState->mDeferredLocalAssignData->mHadFallthrough;
blockIdx++;
}