Removed lifetime.start and lifetime.end for LLVM

The lifetime annotations were causing errors in release builds, related to stack colorization

IDEHelper/Backend/BeIRCodeGen.cpp

@@ -1424,6 +1424,9 @@ void BeIRCodeGen::HandleNextCmd()
 	case BfIRCmd_LifetimeEnd:
 		{
 			CMD_PARAM(BeValue*, val);
+#ifdef _DEBUG
+			val->mLifetimeEnded = true;
+#endif
 			auto inst = mBeModule->AllocInst<BeLifetimeEndInst>();
 			inst->mPtr = val;
 			SetResult(curId, inst);
@@ -3045,6 +3048,9 @@ BeValue* BeIRCodeGen::GetBeValue(int id)
 {
 	auto& result = mResults[id];
 	BF_ASSERT(result.mKind == BeIRCodeGenEntryKind_Value);
+#ifdef _DEBUG
+	BF_ASSERT(!result.mBeValue->mLifetimeEnded);
+#endif
 	return result.mBeValue;
 }
 

IDEHelper/Compiler/BfExprEvaluator.cpp

@@ -12043,6 +12043,7 @@ void BfExprEvaluator::InjectMixin(BfAstNode* targetSrc, BfTypedValue target, boo
 						value = newLocalVar->mConstValue;
 
 					auto aliasValue = mModule->mBfIRBuilder->CreateAliasValue(value);					
+					if (mModule->WantsLifetimes())
 						scopeData.mDeferredLifetimeEnds.Add(aliasValue);					
 
 					if (newLocalVar->mAddr)
@@ -15318,6 +15319,16 @@ void BfExprEvaluator::Visit(BfIndexerExpression* indexerExpr)
 		}
 	}
 
+	if (indexArgument.mType->IsPrimitiveType())
+	{
+		auto primType = (BfPrimitiveType*)indexArgument.mType;
+		if ((!primType->IsSigned()) && (primType->mSize < 8))
+		{
+			// GEP will always do a signed upcast so we need to cast manually if we are unsigned
+			indexArgument = BfTypedValue(mModule->mBfIRBuilder->CreateNumericCast(indexArgument.mValue, false, BfTypeCode_IntPtr), mModule->GetPrimitiveType(BfTypeCode_IntPtr));
+		}
+	}
+
 	mModule->PopulateType(target.mType);
 	if (target.mType->IsSizedArray())
 	{		

IDEHelper/Compiler/BfModule.cpp

@@ -1788,7 +1788,7 @@ BfIRValue BfModule::CreateAlloca(BfType* type, bool addLifetime, const char* nam
 	if (name != NULL)
 		mBfIRBuilder->SetName(allocaInst, name);
 	mBfIRBuilder->SetInsertPoint(prevInsertBlock);	
-	if (addLifetime)
+	if ((addLifetime) && (WantsLifetimes()))
 	{
 		auto lifetimeStart = mBfIRBuilder->CreateLifetimeStart(allocaInst);
 		mBfIRBuilder->ClearDebugLocation(lifetimeStart);
@@ -1812,7 +1812,7 @@ BfIRValue BfModule::CreateAllocaInst(BfTypeInstance* typeInst, bool addLifetime,
 	if (name != NULL)
 		mBfIRBuilder->SetName(allocaInst, name);
 	mBfIRBuilder->SetInsertPoint(prevInsertBlock);
-	if (addLifetime)
+	if ((addLifetime) && (WantsLifetimes()))
 	{
 		auto lifetimeStart = mBfIRBuilder->CreateLifetimeStart(allocaInst);
 		mBfIRBuilder->ClearDebugLocation(lifetimeStart);
@@ -7456,9 +7456,12 @@ BfIRValue BfModule::AllocFromType(BfType* type, const BfAllocTarget& allocTarget
 					castedVal = mBfIRBuilder->CreateBitCast(allocaInst, mBfIRBuilder->MapTypeInstPtr(typeInstance));
 					mBfIRBuilder->ClearDebugLocation(castedVal);
 					mBfIRBuilder->SetInsertPoint(prevBlock);
+					if (WantsLifetimes())
+					{
 						mBfIRBuilder->CreateLifetimeStart(allocaInst);
 						scopeData->mDeferredLifetimeEnds.push_back(allocaInst);
 					}
+				}
 				else
 				{
 					castedVal = mBfIRBuilder->CreateBitCast(allocaInst, mBfIRBuilder->MapTypeInstPtr(typeInstance));
@@ -7507,9 +7510,12 @@ BfIRValue BfModule::AllocFromType(BfType* type, const BfAllocTarget& allocTarget
 			{
 				mBfIRBuilder->ClearDebugLocation(allocaInst);
 				mBfIRBuilder->SetInsertPoint(prevBlock);
+				if (WantsLifetimes())
+				{
 					mBfIRBuilder->CreateLifetimeStart(allocaInst);
 					scopeData->mDeferredLifetimeEnds.push_back(allocaInst);
 				}
+			}
 			if (!noDtorCall)
 				AddStackAlloc(typedVal, NULL, scopeData, false, true);
 			if (typeInstance != NULL)
@@ -7941,6 +7947,13 @@ bool BfModule::IsTargetingBeefBackend()
 	return GetModuleOptions().mOptLevel == BfOptLevel_OgPlus;
 }
 
+bool BfModule::WantsLifetimes()
+{
+	if (mProject == NULL)
+		return false;
+	return GetModuleOptions().mOptLevel == BfOptLevel_OgPlus;
+}
+
 bool BfModule::HasCompiledOutput()
 {
 	return (!mSystem->mIsResolveOnly) && (mIsReified);
@@ -11793,7 +11806,7 @@ BfIRValue BfModule::AllocLocalVariable(BfType* type, const StringImpl& name, boo
 		return mBfIRBuilder->GetFakeVal();	
 
 	auto allocaInst = CreateAlloca(type, doLifetimeEnd, name.c_str());
-	if (!doLifetimeEnd)
+	if ((!doLifetimeEnd) && (WantsLifetimes()))
 	{
 		auto lifetimeStart = mBfIRBuilder->CreateLifetimeStart(allocaInst);
 		mBfIRBuilder->ClearDebugLocation(lifetimeStart);
@@ -15969,6 +15982,7 @@ void BfModule::ProcessMethod(BfMethodInstance* methodInstance, bool isInlineDup)
 					mBfIRBuilder->SetAllocaAlignment(allocaInst, checkType->mAlign);
 					if (!paramVar->mAddr)
 						paramVar->mAddr = allocaInst;
+					if (WantsLifetimes())
 						mCurMethodState->mCurScope->mDeferredLifetimeEnds.push_back(allocaInst);
 					splatAddrValues.push_back(allocaInst);
 				}, paramVar->mResolvedType);
@@ -15989,6 +16003,7 @@ void BfModule::ProcessMethod(BfMethodInstance* methodInstance, bool isInlineDup)
 							mBfIRBuilder->SetName(allocaInst, paramVar->mName + ".addr");
 							mBfIRBuilder->SetAllocaAlignment(allocaInst, thisType->mAlign);
 							paramVar->mAddr = allocaInst;
+							if (WantsLifetimes())
 								mCurMethodState->mCurScope->mDeferredLifetimeEnds.push_back(allocaInst);
 						}												
 					}
@@ -16007,6 +16022,7 @@ void BfModule::ProcessMethod(BfMethodInstance* methodInstance, bool isInlineDup)
 						mBfIRBuilder->SetName(allocaInst, paramVar->mName + ".addr");
 						mBfIRBuilder->SetAllocaAlignment(allocaInst, mSystem->mPtrSize);
 						paramVar->mAddr = allocaInst;
+						if (WantsLifetimes())
 							mCurMethodState->mCurScope->mDeferredLifetimeEnds.push_back(allocaInst);
 					}
 					mBfIRBuilder->SetInsertPoint(prevInsert);
@@ -16046,6 +16062,7 @@ void BfModule::ProcessMethod(BfMethodInstance* methodInstance, bool isInlineDup)
 					mBfIRBuilder->SetAllocaAlignment(allocaInst, alignSize);
 					paramVar->mAddr = allocaInst;
 					mBfIRBuilder->SetInsertPoint(prevInsert);		
+					if (WantsLifetimes())
 						mCurMethodState->mCurScope->mDeferredLifetimeEnds.push_back(allocaInst);
 				}
 			}

IDEHelper/Compiler/BfModule.h

@@ -1460,6 +1460,7 @@ public:
 	void EmitAppendAlign(int align, int sizeMultiple = 0);
 	BfIRValue AppendAllocFromType(BfType* type, BfIRValue appendSizeValue = BfIRValue(), int appendAllocAlign = 0, BfIRValue arraySize = BfIRValue(), int arrayDim = 0, bool isRawArrayAlloc = false, bool zeroMemory = true);	
 	bool IsTargetingBeefBackend();
+	bool WantsLifetimes();
 	bool HasCompiledOutput();
 	void SkipObjectAccessCheck(BfTypedValue typedVal);
 	void EmitObjectAccessCheck(BfTypedValue typedVal);	

IDEHelper/Compiler/BfStmtEvaluator.cpp

@@ -84,9 +84,11 @@ bool BfModule::AddDeferredCallEntry(BfDeferredCallEntry* deferredCallEntry, BfSc
 					auto allocaInst = mBfIRBuilder->CreateAlloca(origParamTypes[paramIdx]);
 					mBfIRBuilder->ClearDebugLocation(allocaInst);
 					mBfIRBuilder->SetInsertPoint(prevInsertBlock);
+					if (WantsLifetimes())
 						mBfIRBuilder->CreateLifetimeStart(allocaInst);
 					mBfIRBuilder->CreateStore(scopeArg, allocaInst);
 					deferredCallEntry->mScopeArgs[paramIdx] = allocaInst;
+					if (WantsLifetimes())
 						scopeData->mDeferredLifetimeEnds.push_back(allocaInst);
 				}
 				deferredCallEntry->mArgsNeedLoad = true;
@@ -120,6 +122,7 @@ bool BfModule::AddDeferredCallEntry(BfDeferredCallEntry* deferredCallEntry, BfSc
 		if (!mBfIRBuilder->mIgnoreWrites)
 		{
 			listEntry->mDynCallTail = CreateAlloca(deferredCallEntryTypePtr, false, "deferredCallTail");
+			if (WantsLifetimes())
 				scopeData->mDeferredLifetimeEnds.push_back(listEntry->mDynCallTail);
 
 			auto prevInsertBlock = mBfIRBuilder->GetInsertBlock();
@@ -129,6 +132,7 @@ bool BfModule::AddDeferredCallEntry(BfDeferredCallEntry* deferredCallEntry, BfSc
 			auto scopeHead = &mCurMethodState->mHeadScope;
 			mBfIRBuilder->SetCurrentDebugLocation(mCurFilePosition.mCurLine + 1, 0, scopeHead->mDIScope, BfIRMDNode());
 
+			if (WantsLifetimes())
 				mBfIRBuilder->CreateLifetimeStart(listEntry->mDynCallTail);
 			auto storeInst = mBfIRBuilder->CreateStore(GetDefaultValue(deferredCallEntryTypePtr), listEntry->mDynCallTail);
 			mBfIRBuilder->ClearDebugLocation(storeInst);
@@ -1590,6 +1594,7 @@ BfLocalVariable* BfModule::HandleVariableDeclaration(BfVariableDeclaration* varD
 			if (localDef->mIsReadOnly)
 				localDef->mValue = mBfIRBuilder->CreateLoad(localDef->mAddr);			
 		}		
+		if (WantsLifetimes())
 			mCurMethodState->mCurScope->mDeferredLifetimeEnds.push_back(localDef->mAddr);
 	}