Extern/Beef
1
0
Fork 0
mirror of https://github.com/beefytech/Beef.git synced 2025-06-08 03:28:20 +02:00
Code Activity

Fixed default rollback in minidumps

Browse source
This commit is contained in:
Brian Fiete 2020-04-20 06:58:51 -07:00
parent f77ccb8994
commit b0e5991934
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
IDEHelper/DebugTarget.cpp
View file

@ -850,7 +850,7 @@ DbgSubprogram* DebugTarget::FindSubProgram(addr_target pc, DbgOnDemandKind onDem
}
if (module->RequestDebugInfo(onDemandKind == DbgOnDemandKind_AllowRemote))
{
{
// Give another chance to ParseCompileUnit and then match again
found = true;
pass = -1;
@ -2071,13 +2071,15 @@ bool DebugTarget::RollBackStackFrame(CPURegisters* registers, addr_target* outRe
// Fall through after this, we need to process a 'return'
bool alreadyRolledBackPC = false;
bool success = RollBackStackFrame_ExceptionDirectory(registers, outReturnAddressLoc, alreadyRolledBackPC);
if (!success)
{
if (mDebugger->IsMiniDumpDebugger())
{
return false;
}
}
///TODO: Why did we break when there was a minidump? This breaks default-rollback of just a 'ret'
// if (!success)
// {
// if (mDebugger->IsMiniDumpDebugger())
// {
// return false;
// }
// }
if (alreadyRolledBackPC)
return true;