Extern/Beef
1
0
Fork 0
mirror of https://github.com/beefytech/Beef.git synced 2025-06-11 04:52:21 +02:00
Code Activity

Fixed erroneous autoprop optimization when getter or setter has a body

Browse source
This commit is contained in:
Brian Fiete 2021-06-29 16:02:42 -07:00
parent 78c39c5f87
commit 91897f8cb3
1 changed files with 34 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

57
IDEHelper/Compiler/BfExprEvaluator.cpp
View file

@ -4871,34 +4871,45 @@ BfTypedValue BfExprEvaluator::LookupField(BfAstNode* targetSrc, BfTypedValue tar
{ {
if ((curCheckType->mTypeDef->HasAutoProperty(propertyDeclaration)) && (propertyDeclaration->mVirtualSpecifier == NULL)) if ((curCheckType->mTypeDef->HasAutoProperty(propertyDeclaration)) && (propertyDeclaration->mVirtualSpecifier == NULL))
{ {
bool hasSetter = GetPropertyMethodDef(mPropDef, BfMethodType_PropertySetter, BfCheckedKind_NotSet, mPropTarget) != NULL; BfMethodDef* getter = GetPropertyMethodDef(mPropDef, BfMethodType_PropertySetter, BfCheckedKind_NotSet, mPropTarget);
auto autoFieldName = curCheckType->mTypeDef->GetAutoPropertyName(propertyDeclaration); BfMethodDef* setter = GetPropertyMethodDef(mPropDef, BfMethodType_PropertySetter, BfCheckedKind_NotSet, mPropTarget);
auto result = LookupField(targetSrc, target, autoFieldName, (BfLookupFieldFlags)(BfLookupFieldFlag_IgnoreProtection | BfLookupFieldFlag_IsImplicitThis));
if (result) bool optAllowed = true;
if ((getter != NULL) && (getter->mBody != NULL))
optAllowed = false;
if ((setter != NULL) && (setter->mBody != NULL))
optAllowed = false;
if (optAllowed)
{ {
bool needsCopy = true; auto autoFieldName = curCheckType->mTypeDef->GetAutoPropertyName(propertyDeclaration);
auto result = LookupField(targetSrc, target, autoFieldName, (BfLookupFieldFlags)(BfLookupFieldFlag_IgnoreProtection | BfLookupFieldFlag_IsImplicitThis));
if (!hasSetter) if (result)
{ {
if (((mModule->mCurMethodInstance->mMethodDef->mMethodType == BfMethodType_Ctor)) && bool needsCopy = true;
(startCheckType == mModule->mCurTypeInstance))
if (setter == NULL)
{ {
// Allow writing inside ctor if (((mModule->mCurMethodInstance->mMethodDef->mMethodType == BfMethodType_Ctor)) &&
} (startCheckType == mModule->mCurTypeInstance))
else {
{ // Allow writing inside ctor
result.MakeReadOnly(); }
needsCopy = false; else
{
result.MakeReadOnly();
needsCopy = false;
}
} }
if (result.mKind == BfTypedValueKind_Addr)
result.mKind = BfTypedValueKind_CopyOnMutateAddr;
mPropDef = NULL;
mPropSrc = NULL;
mOrigPropTarget = NULL;
return result;
} }
if (result.mKind == BfTypedValueKind_Addr)
result.mKind = BfTypedValueKind_CopyOnMutateAddr;
mPropDef = NULL;
mPropSrc = NULL;
mOrigPropTarget = NULL;
return result;
} }
} }
} }