1
0
Fork 0
mirror of https://github.com/beefytech/Beef.git synced 2025-06-14 14:24:10 +02:00

Added option to toggle between classic and fuzzy autocomplete

This commit is contained in:
Simon Lübeß 2021-12-25 20:14:23 +01:00
parent ac99191487
commit 8f0502972f
9 changed files with 172 additions and 36 deletions

View file

@ -78,6 +78,8 @@ namespace IDE.Compiler
public bool mCancelled; public bool mCancelled;
public int32 mTextVersion = -1; public int32 mTextVersion = -1;
public bool mIsUserRequested; public bool mIsUserRequested;
public bool mDoFuzzyAutoComplete;
} }
public class BfParser : ILeakIdentifiable public class BfParser : ILeakIdentifiable
@ -126,7 +128,7 @@ namespace IDE.Compiler
static extern char8* BfParser_GetDebugExpressionAt(void* bfParser, int32 cursorIdx); static extern char8* BfParser_GetDebugExpressionAt(void* bfParser, int32 cursorIdx);
[CallingConvention(.Stdcall), CLink] [CallingConvention(.Stdcall), CLink]
static extern void* BfParser_CreateResolvePassData(void* bfSystem, int32 resolveType); static extern void* BfParser_CreateResolvePassData(void* bfSystem, int32 resolveType, bool doFuzzyAutoComplete);
[CallingConvention(.Stdcall), CLink] [CallingConvention(.Stdcall), CLink]
static extern bool BfParser_BuildDefs(void* bfParser, void* bfPassInstance, void* bfResolvePassData, bool fullRefresh); static extern bool BfParser_BuildDefs(void* bfParser, void* bfPassInstance, void* bfResolvePassData, bool fullRefresh);
@ -253,10 +255,10 @@ namespace IDE.Compiler
BfParser_GenerateAutoCompletionFrom(mNativeBfParser, srcPosition); BfParser_GenerateAutoCompletionFrom(mNativeBfParser, srcPosition);
} }
public BfResolvePassData CreateResolvePassData(ResolveType resolveType = ResolveType.Autocomplete) public BfResolvePassData CreateResolvePassData(ResolveType resolveType = ResolveType.Autocomplete, bool doFuzzyAutoComplete = false)
{ {
var resolvePassData = new BfResolvePassData(); var resolvePassData = new BfResolvePassData();
resolvePassData.mNativeResolvePassData = BfParser_CreateResolvePassData(mNativeBfParser, (int32)resolveType); resolvePassData.mNativeResolvePassData = BfParser_CreateResolvePassData(mNativeBfParser, (int32)resolveType, doFuzzyAutoComplete);
return resolvePassData; return resolvePassData;
} }

View file

@ -94,10 +94,10 @@ namespace IDE.Compiler
BfResolvePassData_SetDocumentationRequest(mNativeResolvePassData, entryName); BfResolvePassData_SetDocumentationRequest(mNativeResolvePassData, entryName);
} }
public static BfResolvePassData Create(ResolveType resolveType = ResolveType.Autocomplete) public static BfResolvePassData Create(ResolveType resolveType = ResolveType.Autocomplete, bool doFuzzyAutoComplete = false)
{ {
var resolvePassData = new BfResolvePassData(); var resolvePassData = new BfResolvePassData();
resolvePassData.mNativeResolvePassData = BfParser.[Friend]BfParser_CreateResolvePassData(null, (int32)resolveType); resolvePassData.mNativeResolvePassData = BfParser.[Friend]BfParser_CreateResolvePassData(null, (int32)resolveType, doFuzzyAutoComplete);
return resolvePassData; return resolvePassData;
} }
} }

View file

@ -604,7 +604,7 @@ namespace IDE
No, No,
Yes, Yes,
BackupOnly BackupOnly
} }
public List<String> mFonts = new .() ~ DeleteContainerAndItems!(_); public List<String> mFonts = new .() ~ DeleteContainerAndItems!(_);
public float mFontSize = 12; public float mFontSize = 12;
@ -613,6 +613,7 @@ namespace IDE
public bool mAutoCompleteRequireTab = false; public bool mAutoCompleteRequireTab = false;
public bool mAutoCompleteOnEnter = true; public bool mAutoCompleteOnEnter = true;
public bool mAutoCompleteShowDocumentation = true; public bool mAutoCompleteShowDocumentation = true;
public bool mFuzzyAutoComplete = false;
public bool mShowLocatorAnim = true; public bool mShowLocatorAnim = true;
public bool mHiliteCursorReferences = true; public bool mHiliteCursorReferences = true;
public bool mLockEditing; public bool mLockEditing;
@ -639,6 +640,7 @@ namespace IDE
sd.Add("AutoCompleteRequireTab", mAutoCompleteRequireTab); sd.Add("AutoCompleteRequireTab", mAutoCompleteRequireTab);
sd.Add("AutoCompleteOnEnter", mAutoCompleteOnEnter); sd.Add("AutoCompleteOnEnter", mAutoCompleteOnEnter);
sd.Add("AutoCompleteShowDocumentation", mAutoCompleteShowDocumentation); sd.Add("AutoCompleteShowDocumentation", mAutoCompleteShowDocumentation);
sd.Add("FuzzyAutoComplete", mFuzzyAutoComplete);
sd.Add("ShowLocatorAnim", mShowLocatorAnim); sd.Add("ShowLocatorAnim", mShowLocatorAnim);
sd.Add("HiliteCursorReferences", mHiliteCursorReferences); sd.Add("HiliteCursorReferences", mHiliteCursorReferences);
sd.Add("LockEditing", mLockEditing); sd.Add("LockEditing", mLockEditing);
@ -668,6 +670,7 @@ namespace IDE
sd.Get("AutoCompleteRequireTab", ref mAutoCompleteRequireTab); sd.Get("AutoCompleteRequireTab", ref mAutoCompleteRequireTab);
sd.Get("AutoCompleteOnEnter", ref mAutoCompleteOnEnter); sd.Get("AutoCompleteOnEnter", ref mAutoCompleteOnEnter);
sd.Get("AutoCompleteShowDocumentation", ref mAutoCompleteShowDocumentation); sd.Get("AutoCompleteShowDocumentation", ref mAutoCompleteShowDocumentation);
sd.Get("FuzzyAutoComplete", ref mFuzzyAutoComplete);
sd.Get("ShowLocatorAnim", ref mShowLocatorAnim); sd.Get("ShowLocatorAnim", ref mShowLocatorAnim);
sd.Get("HiliteCursorReferences", ref mHiliteCursorReferences); sd.Get("HiliteCursorReferences", ref mHiliteCursorReferences);
sd.Get("LockEditing", ref mLockEditing); sd.Get("LockEditing", ref mLockEditing);

View file

@ -1615,7 +1615,7 @@ namespace IDE.ui
static extern bool fts_fuzzy_match(char8* pattern, char8* str, ref int32 outScore, uint8* matches, int maxMatches); static extern bool fts_fuzzy_match(char8* pattern, char8* str, ref int32 outScore, uint8* matches, int maxMatches);
/// Checks whether the given entry matches the filter and updates its score and match indices accordingly. /// Checks whether the given entry matches the filter and updates its score and match indices accordingly.
bool UpdateFilterMatch(AutoCompleteListWidget.EntryWidget entry, String filter) bool DoesFilterMatchFuzzy(AutoCompleteListWidget.EntryWidget entry, String filter)
{ {
if (filter.Length == 0) if (filter.Length == 0)
return true; return true;
@ -1653,6 +1653,72 @@ namespace IDE.ui
return true; return true;
} }
bool DoesFilterMatch(String entry, String filter)
{
if (filter.Length == 0)
return true;
char8* entryPtr = entry.Ptr;
char8* filterPtr = filter.Ptr;
int filterLen = (int)filter.Length;
int entryLen = (int)entry.Length;
bool hasUnderscore = false;
bool checkInitials = filterLen > 1;
for (int i = 0; i < (int)filterLen; i++)
{
char8 c = filterPtr[i];
if (c == '_')
hasUnderscore = true;
else if (filterPtr[i].IsLower)
checkInitials = false;
}
if (hasUnderscore)
//return strnicmp(filter, entry, filterLen) == 0;
return (entryLen >= filterLen) && (String.Compare(entryPtr, filterLen, filterPtr, filterLen, true) == 0);
char8[256] initialStr;
char8* initialStrP = &initialStr;
//String initialStr;
bool prevWasUnderscore = false;
for (int entryIdx = 0; entryIdx < entryLen; entryIdx++)
{
char8 entryC = entryPtr[entryIdx];
if (entryC == '_')
{
prevWasUnderscore = true;
continue;
}
if ((entryIdx == 0) || (prevWasUnderscore) || (entryC.IsUpper) || (entryC.IsDigit))
{
/*if (strnicmp(filter, entry + entryIdx, filterLen) == 0)
return true;*/
if ((entryLen - entryIdx >= filterLen) && (String.Compare(entryPtr + entryIdx, filterLen, filterPtr, filterLen, true) == 0))
return true;
if (checkInitials)
*(initialStrP++) = entryC;
}
prevWasUnderscore = false;
if (filterLen == 1)
break; // Don't check inners for single-character case
}
if (!checkInitials)
return false;
int initialLen = initialStrP - (char8*)&initialStr;
return (initialLen >= filterLen) && (String.Compare(&initialStr, filterLen, filterPtr, filterLen, true) == 0);
//*(initialStrP++) = 0;
//return strnicmp(filter, initialStr, filterLen) == 0;
}
[LinkName("_stricmp")] [LinkName("_stricmp")]
static extern int32 stricmp(char8* lhs, char8* rhs); static extern int32 stricmp(char8* lhs, char8* rhs);
@ -1708,14 +1774,22 @@ namespace IDE.ui
if (curString == ".") if (curString == ".")
curString.Clear(); curString.Clear();
bool doFuzzyAutoComplete = gApp.mSettings.mEditorSettings.mFuzzyAutoComplete;
for (int i < mAutoCompleteListWidget.mFullEntryList.Count) for (int i < mAutoCompleteListWidget.mFullEntryList.Count)
{ {
var entry = mAutoCompleteListWidget.mFullEntryList[i]; var entry = mAutoCompleteListWidget.mFullEntryList[i];
if (UpdateFilterMatch(entry, curString)) if (doFuzzyAutoComplete && DoesFilterMatchFuzzy(entry, curString))
{ {
mAutoCompleteListWidget.mEntryList.Add(entry); mAutoCompleteListWidget.mEntryList.Add(entry);
visibleCount++; visibleCount++;
}
else if (!doFuzzyAutoComplete && DoesFilterMatch(entry.mEntryDisplay, curString))
{
mAutoCompleteListWidget.mEntryList.Add(entry);
mAutoCompleteListWidget.UpdateEntry(entry, visibleCount);
visibleCount++;
} }
else else
{ {
@ -1723,20 +1797,23 @@ namespace IDE.ui
} }
} }
// sort entries because the scores probably have changed if (doFuzzyAutoComplete)
mAutoCompleteListWidget.mEntryList.Sort(scope (left, right) =>
{
if (left.mScore > right.mScore)
return -1;
else if (left.mScore < right.mScore)
return 1;
else
return ((stricmp(left.mEntryDisplay.CStr(), right.mEntryDisplay.CStr()) < 0) ? -1 : 1);
});
for (int i < mAutoCompleteListWidget.mEntryList.Count)
{ {
mAutoCompleteListWidget.UpdateEntry(mAutoCompleteListWidget.mEntryList[i], i); // sort entries because the scores probably have changed
mAutoCompleteListWidget.mEntryList.Sort(scope (left, right) =>
{
if (left.mScore > right.mScore)
return -1;
else if (left.mScore < right.mScore)
return 1;
else
return ((stricmp(left.mEntryDisplay.CStr(), right.mEntryDisplay.CStr()) < 0) ? -1 : 1);
});
for (int i < mAutoCompleteListWidget.mEntryList.Count)
{
mAutoCompleteListWidget.UpdateEntry(mAutoCompleteListWidget.mEntryList[i], i);
}
} }
if ((visibleCount == 0) && (mInvokeSrcPositions == null)) if ((visibleCount == 0) && (mInvokeSrcPositions == null))

View file

@ -98,6 +98,7 @@ namespace IDE.ui
AddPropertiesItem(category, "Autocomplete Require Tab", "mAutoCompleteRequireTab"); AddPropertiesItem(category, "Autocomplete Require Tab", "mAutoCompleteRequireTab");
AddPropertiesItem(category, "Autocomplete on Enter", "mAutoCompleteOnEnter"); AddPropertiesItem(category, "Autocomplete on Enter", "mAutoCompleteOnEnter");
AddPropertiesItem(category, "Autocomplete Show Documentation", "mAutoCompleteShowDocumentation"); AddPropertiesItem(category, "Autocomplete Show Documentation", "mAutoCompleteShowDocumentation");
AddPropertiesItem(category, "Fuzzy Autocomplete", "mFuzzyAutoComplete");
AddPropertiesItem(category, "Show Locator Animation", "mShowLocatorAnim"); AddPropertiesItem(category, "Show Locator Animation", "mShowLocatorAnim");
AddPropertiesItem(category, "Hilite Symbol at Cursor", "mHiliteCursorReferences"); AddPropertiesItem(category, "Hilite Symbol at Cursor", "mHiliteCursorReferences");

View file

@ -622,6 +622,7 @@ namespace IDE.ui
ResolveParams resolveParams = new ResolveParams(); ResolveParams resolveParams = new ResolveParams();
resolveParams.mIsUserRequested = options.HasFlag(.UserRequested); resolveParams.mIsUserRequested = options.HasFlag(.UserRequested);
resolveParams.mDoFuzzyAutoComplete = gApp.mSettings.mEditorSettings.mFuzzyAutoComplete;
Classify(.Autocomplete, resolveParams); Classify(.Autocomplete, resolveParams);
if (!resolveParams.mInDeferredList) if (!resolveParams.mInDeferredList)
delete resolveParams; delete resolveParams;
@ -1853,7 +1854,9 @@ namespace IDE.ui
/*else (!isFullClassify) -- do we ever need to do this? /*else (!isFullClassify) -- do we ever need to do this?
parser.SetCursorIdx(mEditWidget.mEditWidgetContent.CursorTextPos);*/ parser.SetCursorIdx(mEditWidget.mEditWidgetContent.CursorTextPos);*/
var resolvePassData = parser.CreateResolvePassData(resolveType); bool doFuzzyAutoComplete = resolveParams?.mDoFuzzyAutoComplete ?? false;
var resolvePassData = parser.CreateResolvePassData(resolveType, doFuzzyAutoComplete);
if (resolveParams != null) if (resolveParams != null)
{ {
if (resolveParams.mLocalId != -1) if (resolveParams.mLocalId != -1)

View file

@ -19,6 +19,7 @@ AutoCompleteBase::AutoCompleteBase()
{ {
mIsGetDefinition = false; mIsGetDefinition = false;
mIsAutoComplete = true; mIsAutoComplete = true;
mDoFuzzyAutoComplete = false;
mInsertStartIdx = -1; mInsertStartIdx = -1;
mInsertEndIdx = -1; mInsertEndIdx = -1;
} }
@ -45,8 +46,6 @@ inline void UpdateEntryMatchindices(uint8* matches, AutoCompleteEntry& entry)
} }
} }
//assert(entry.mMatches != nullptr);
entry.mMatches = matches; entry.mMatches = matches;
} }
else else
@ -129,23 +128,71 @@ bool AutoCompleteBase::DoesFilterMatch(const char* entry, const char* filter, in
if (!mIsAutoComplete) if (!mIsAutoComplete)
return false; return false;
matches[0] = UINT8_MAX;
if (filter[0] == '\0') if (filter[0] == '\0')
{
// Kinda dirty
matches[0] = UINT8_MAX;
matches[1] = 0;
return true; return true;
}
int filterLen = (int)strlen(filter); int filterLen = (int)strlen(filter);
int entryLen = (int)strlen(entry); int entryLen = (int)strlen(entry);
if (filterLen > entryLen) if (filterLen > entryLen)
{
return false; return false;
}
return fts::fuzzy_match(filter, entry, score, matches, maxMatches); if (mDoFuzzyAutoComplete)
{
return fts::fuzzy_match(filter, entry, score, matches, maxMatches);
}
else
{
bool hasUnderscore = false;
bool checkInitials = filterLen > 1;
for (int i = 0; i < (int)filterLen; i++)
{
char c = filter[i];
if (c == '_')
hasUnderscore = true;
else if (islower((uint8)filter[i]))
checkInitials = false;
}
if (hasUnderscore)
return strnicmp(filter, entry, filterLen) == 0;
char initialStr[256];
char* initialStrP = initialStr;
//String initialStr;
bool prevWasUnderscore = false;
for (int entryIdx = 0; entryIdx < entryLen; entryIdx++)
{
char entryC = entry[entryIdx];
if (entryC == '_')
{
prevWasUnderscore = true;
continue;
}
if ((entryIdx == 0) || (prevWasUnderscore) || (isupper((uint8)entryC) || (isdigit((uint8)entryC))))
{
if (strnicmp(filter, entry + entryIdx, filterLen) == 0)
return true;
if (checkInitials)
*(initialStrP++) = entryC;
}
prevWasUnderscore = false;
if (filterLen == 1)
break; // Don't check inners for single-character case
}
if (!checkInitials)
return false;
*(initialStrP++) = 0;
return strnicmp(filter, initialStr, filterLen) == 0;
}
} }
void AutoCompleteBase::Clear() void AutoCompleteBase::Clear()
@ -157,7 +204,7 @@ void AutoCompleteBase::Clear()
////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////
BfAutoComplete::BfAutoComplete(BfResolveType resolveType) BfAutoComplete::BfAutoComplete(BfResolveType resolveType, bool doFuzzyAutoComplete)
{ {
mResolveType = resolveType; mResolveType = resolveType;
mModule = NULL; mModule = NULL;
@ -174,6 +221,8 @@ BfAutoComplete::BfAutoComplete(BfResolveType resolveType)
(resolveType == BfResolveType_GoToDefinition); (resolveType == BfResolveType_GoToDefinition);
mIsAutoComplete = (resolveType == BfResolveType_Autocomplete); mIsAutoComplete = (resolveType == BfResolveType_Autocomplete);
mDoFuzzyAutoComplete = doFuzzyAutoComplete;
mGetDefinitionNode = NULL; mGetDefinitionNode = NULL;
mShowAttributeProperties = NULL; mShowAttributeProperties = NULL;
mIdentifierUsed = NULL; mIdentifierUsed = NULL;

View file

@ -111,6 +111,7 @@ public:
bool mIsGetDefinition; bool mIsGetDefinition;
bool mIsAutoComplete; bool mIsAutoComplete;
bool mDoFuzzyAutoComplete;
int mInsertStartIdx; int mInsertStartIdx;
int mInsertEndIdx; int mInsertEndIdx;
@ -240,7 +241,7 @@ public:
String ConstantToString(BfIRConstHolder* constHolder, BfIRValue id); String ConstantToString(BfIRConstHolder* constHolder, BfIRValue id);
public: public:
BfAutoComplete(BfResolveType resolveType = BfResolveType_Autocomplete); BfAutoComplete(BfResolveType resolveType = BfResolveType_Autocomplete, bool doFuzzyAutoComplete = false);
~BfAutoComplete(); ~BfAutoComplete();
void SetModule(BfModule* module); void SetModule(BfModule* module);

View file

@ -3897,13 +3897,13 @@ BF_EXPORT const char* BF_CALLTYPE BfParser_GetDebugExpressionAt(BfParser* bfPars
return outString.c_str(); return outString.c_str();
} }
BF_EXPORT BfResolvePassData* BF_CALLTYPE BfParser_CreateResolvePassData(BfParser* bfParser, BfResolveType resolveType) BF_EXPORT BfResolvePassData* BF_CALLTYPE BfParser_CreateResolvePassData(BfParser* bfParser, BfResolveType resolveType, bool doFuzzyAutoComplete)
{ {
auto bfResolvePassData = new BfResolvePassData(); auto bfResolvePassData = new BfResolvePassData();
bfResolvePassData->mResolveType = resolveType; bfResolvePassData->mResolveType = resolveType;
bfResolvePassData->mParser = bfParser; bfResolvePassData->mParser = bfParser;
if ((bfParser != NULL) && ((bfParser->mParserFlags & ParserFlag_Autocomplete) != 0)) if ((bfParser != NULL) && ((bfParser->mParserFlags & ParserFlag_Autocomplete) != 0))
bfResolvePassData->mAutoComplete = new BfAutoComplete(resolveType); bfResolvePassData->mAutoComplete = new BfAutoComplete(resolveType, doFuzzyAutoComplete);
return bfResolvePassData; return bfResolvePassData;
} }