Extern/Beef
1
0
Fork 0
mirror of https://github.com/beefytech/Beef.git synced 2025-06-10 04:22:20 +02:00
Code Activity

Improved warning taking address of parameters

Browse source
This commit is contained in:
Brian Fiete 2022-05-21 11:58:26 -07:00
parent 56cc35f266
commit 7f340f7c82
1 changed files with 18 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

22
IDEHelper/Compiler/BfExprEvaluator.cpp
View file

@ -18863,14 +18863,28 @@ bool BfExprEvaluator::CheckModifyResult(BfTypedValue& typedVal, BfAstNode* refNo
if (!mModule->mCurMethodInstance->IsMixin())
{
if (mModule->mCurMethodState->mMixinState != NULL)
{
error = _Fail(StrFormat("Cannot %s mixin parameter '%s'", modifyType,
localVar->mName.c_str()), refNode);
}
else if ((onlyNeedsMut) && (localVar->mResolvedType != NULL) && (localVar->mResolvedType->IsGenericParam()))
error = _Fail(StrFormat("Cannot %s parameter '%s'. Consider adding 'mut' or 'ref' specifier to parameter or declaring 'var %s;' to create a mutable copy.", modifyType,
localVar->mName.c_str(), localVar->mName.c_str()), refNode);
{
if (emitWarning)
error = _Fail(StrFormat("The address of '%s' may be temporary or immutable. Consider adding 'mut' or 'ref' specifier to parameter or declaring 'var %s;' to create a mutable copy.",
localVar->mName.c_str(), localVar->mName.c_str()), refNode);
else
error = _Fail(StrFormat("Cannot %s parameter '%s'. Consider adding 'mut' or 'ref' specifier to parameter or declaring 'var %s;' to create a mutable copy.", modifyType,
localVar->mName.c_str(), localVar->mName.c_str()), refNode);
}
else
error = _Fail(StrFormat("Cannot %s parameter '%s'. Consider adding 'ref' specifier to parameter or declaring 'var %s;' to create a mutable copy.", modifyType,
localVar->mName.c_str(), localVar->mName.c_str()), refNode);
{
if (emitWarning)
error = _Fail(StrFormat("The address of '%s' may be temporary or immutable. Consider adding 'ref' specifier to parameter or declaring 'var %s;' to create a mutable copy.",
localVar->mName.c_str(), localVar->mName.c_str()), refNode);
else
error = _Fail(StrFormat("Cannot %s parameter '%s'. Consider adding 'ref' specifier to parameter or declaring 'var %s;' to create a mutable copy.", modifyType,
localVar->mName.c_str(), localVar->mName.c_str()), refNode);
}
return false;
}
}