Extern/Beef
1
0
Fork 0
mirror of https://github.com/beefytech/Beef.git synced 2025-07-04 23:36:00 +02:00
Code Activity

Remove unnecessary delete statements

Browse source 
If a value is null, the C++ delete statement will do nothing, so there is bo need to explicitly check if the value is null.
This commit is contained in:
JamesOrson 2020-07-10 15:43:39 -07:00 • committed by James Orson
parent 43187e233a
commit 5f3329e121
12 changed files with 22 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

3
BeefySysLib/FileHandleStream.cpp
View file

@ -13,8 +13,7 @@ FileHandleStream::FileHandleStream()
FileHandleStream::~FileHandleStream()
{
if (mCacheBuffer != NULL)
delete mCacheBuffer;
delete mCacheBuffer;
if (mFileHandle != NULL)
::CloseHandle_File(mFileHandle);
}

3
BeefySysLib/FileStream.cpp
View file

@ -16,8 +16,7 @@ FileStream::FileStream()
FileStream::~FileStream()
{
if (mCacheBuffer != NULL)
delete mCacheBuffer;
delete mCacheBuffer;
if (mFP != NULL)
fclose(mFP);
}

3
BeefySysLib/img/PSDReader.cpp
View file

@ -176,8 +176,7 @@ PSDReader::PSDReader()
PSDReader::~PSDReader()
{
if (mFS != NULL)
delete mFS;
delete mFS;
for (int i = 0; i < (int) mPSDLayerInfoVector.size(); i++)
delete mPSDLayerInfoVector[i];
PSDPatternMap::iterator itr = mPSDPatternMap.begin();

9
BeefySysLib/platform/win/DSoundManager.cpp
View file

@ -417,11 +417,10 @@ void DSoundManager::ReleaseSounds()
void DSoundManager::ReleaseChannels()
{
for (int i = 0; i < MAX_CHANNELS; i++)
if (mPlayingSounds[i] != NULL)
{
delete mPlayingSounds[i];
mPlayingSounds[i] = NULL;
}
{
delete mPlayingSounds[i];
mPlayingSounds[i] = NULL;
}
}
void DSoundManager::ReleaseFreeChannels()

7
BeefySysLib/util/BSpline.cpp
View file

@ -31,11 +31,8 @@ BSpline2D::~BSpline2D()
void BSpline2D::AddPt(float x, float y)
{
if (mUVals != NULL)
{
delete mUVals;
mUVals = NULL;
}
delete mUVals;
mUVals = NULL;
Point2D pt;
pt.mX = x;