Extern/Beef
1
0
Fork 0
mirror of https://github.com/beefytech/Beef.git synced 2025-06-08 03:28:20 +02:00
Code Activity

Warning for mismatching extension generic param anmes

Browse source
This commit is contained in:
Brian Fiete 2023-02-24 06:58:59 -05:00
parent 94b8406fc5
commit 4373381088
1 changed files with 44 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

44
IDEHelper/Compiler/BfCompiler.cpp
View file

@ -3646,6 +3646,50 @@ void BfCompiler::UpdateRevisedTypes()
}
}
}
else
{
for (auto partialTypeDef : compositeTypeDef->GetLatest()->mPartials)
{
if (partialTypeDef->IsExtension())
{
for (int genericParamIdx = 0; genericParamIdx < BF_MIN(partialTypeDef->mGenericParamDefs.mSize, rootTypeDef->mGenericParamDefs.mSize); genericParamIdx++)
{
auto rootParamDef = rootTypeDef->mGenericParamDefs[genericParamIdx];
auto extParamDef = partialTypeDef->mGenericParamDefs[genericParamIdx];
if ((rootParamDef->mName != extParamDef->mName) &&
(!rootParamDef->mNameNodes.IsEmpty()) &&
(!extParamDef->mNameNodes.IsEmpty()))
{
String specializedName = extParamDef->mName;
auto paramDefTypeDef = mSystem->FindTypeDef(extParamDef->mName, 0);
if (paramDefTypeDef != NULL)
{
switch (paramDefTypeDef->mTypeCode)
{
case BfTypeCode_Boolean: specializedName = "Boolean"; break;
default:
if ((paramDefTypeDef->mTypeCode >= BfTypeCode_Boolean) && (paramDefTypeDef->mTypeCode <= BfTypeCode_Double))
{
specializedName[0] = ::toupper(specializedName[0]);
if (specializedName.StartsWith("Uint"))
specializedName[1] = 'I';
}
}
}
auto error = mPassInstance->Warn(0, StrFormat("Extension generic param name '%s' does not match root definition generic param name '%s'. If generic specialization was intended then consider using 'where %s : %s'.",
extParamDef->mName.c_str(), rootParamDef->mName.c_str(), rootParamDef->mName.c_str(), specializedName.c_str()),
extParamDef->mNameNodes[0]);
if (error != NULL)
{
error->mIsPersistent = true;
mPassInstance->MoreInfo("See root definition", rootParamDef->mNameNodes[0]);
}
}
}
}
}
}
}
outerTypeDefEntryIdx = outerTypeDefEntry->mNext;