Extern/Beef
1
0
Fork 0
mirror of https://github.com/beefytech/Beef.git synced 2025-06-10 04:22:20 +02:00
Code Activity

Improved PostRemoveUpdate to avoid pauses on closing tabs

Browse source
This commit is contained in:
Brian Fiete 2022-05-07 16:23:30 -07:00
parent bbd058eeaf
commit 34cfe89d3a
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
IDE/src/IDEApp.bf
View file

@ -6914,7 +6914,15 @@ namespace IDE
int recentFileIdx = -1; int recentFileIdx = -1;
if (sourceViewPanel != null) if (sourceViewPanel != null)
{ {
sourceViewPanel.Dispose(); if (sourceViewPanel.[Friend]NeedsPostRemoveUpdate)
{
sourceViewPanel.[Friend]mDeleteAfterPostRemoveUpdate = true;
tabButton.mContent.RemoveSelf();
tabButton.mContent = null;
}
else
sourceViewPanel.Dispose();
if (sourceViewPanel.mFilePath != null) if (sourceViewPanel.mFilePath != null)
recentFileIdx = GetRecentFilesIdx(sourceViewPanel.mFilePath); recentFileIdx = GetRecentFilesIdx(sourceViewPanel.mFilePath);
} }
@ -14167,6 +14175,8 @@ namespace IDE
//Debug.WriteLine("Removing sourceViewPanel from mPostRemoveUpdatePanel {0} from IDEApp.Update", sourceViewPanel); //Debug.WriteLine("Removing sourceViewPanel from mPostRemoveUpdatePanel {0} from IDEApp.Update", sourceViewPanel);
sourceViewPanel.[Friend]mInPostRemoveUpdatePanels = false; sourceViewPanel.[Friend]mInPostRemoveUpdatePanels = false;
@sourceViewPanel.Remove(); @sourceViewPanel.Remove();
if (sourceViewPanel.[Friend]mDeleteAfterPostRemoveUpdate)
DeferDelete(sourceViewPanel);
} }
} }

1
IDE/src/ui/SourceViewPanel.bf
View file

@ -489,6 +489,7 @@ namespace IDE.ui
int32 mResolveJobCount; int32 mResolveJobCount;
bool mWantsParserCleanup; bool mWantsParserCleanup;
bool mInPostRemoveUpdatePanels; bool mInPostRemoveUpdatePanels;
bool mDeleteAfterPostRemoveUpdate;
// For multi-view files... // For multi-view files...
PersistentTextPosition mTrackCursorPos; PersistentTextPosition mTrackCursorPos;