Extern/Beef
1
0
Fork 0
mirror of https://github.com/beefytech/Beef.git synced 2025-06-14 14:24:10 +02:00
Code Activity

Fix new ObsoleteAttribute constructors

Browse source
This commit is contained in:
disarray2077 2023-01-13 18:39:29 -03:00 • committed by GitHub
parent 3e210999ce
commit 33fc0be429
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

10
IDEHelper/Compiler/BfModule.cpp
View file

@ -3414,7 +3414,7 @@ void BfModule::CheckErrorAttributes(BfTypeInstance* typeInstance, BfMethodInstan
BfIRConstHolder* constHolder = typeInstance->mConstHolder; BfIRConstHolder* constHolder = typeInstance->mConstHolder;
auto customAttribute = customAttributes->Get(mCompiler->mObsoleteAttributeTypeDef); auto customAttribute = customAttributes->Get(mCompiler->mObsoleteAttributeTypeDef);
if ((customAttribute != NULL) && (!customAttribute->mCtorArgs.IsEmpty()) && (targetSrc != NULL)) if ((customAttribute != NULL) && (targetSrc != NULL))
{ {
String err; String err;
if (fieldInstance != NULL) if (fieldInstance != NULL)
@ -3426,12 +3426,14 @@ void BfModule::CheckErrorAttributes(BfTypeInstance* typeInstance, BfMethodInstan
bool isError = false; bool isError = false;
if (customAttribute->mCtorArgs.size() >= 1)
{
auto constant = constHolder->GetConstant(customAttribute->mCtorArgs[0]); auto constant = constHolder->GetConstant(customAttribute->mCtorArgs[0]);
if (constant->mTypeCode == BfTypeCode_Boolean) if (constant->mTypeCode == BfTypeCode_Boolean)
{ {
isError = constant->mBool; isError = constant->mBool;
} }
else if (customAttribute->mCtorArgs.size() >= 2) else if (constant->mTypeCode == BfTypeCode_StringId)
{ {
String* str = GetStringPoolString(customAttribute->mCtorArgs[0], constHolder); String* str = GetStringPoolString(customAttribute->mCtorArgs[0], constHolder);
if (str != NULL) if (str != NULL)
@ -3441,9 +3443,13 @@ void BfModule::CheckErrorAttributes(BfTypeInstance* typeInstance, BfMethodInstan
err += "'"; err += "'";
} }
if (customAttribute->mCtorArgs.size() >= 2)
{
constant = constHolder->GetConstant(customAttribute->mCtorArgs[1]); constant = constHolder->GetConstant(customAttribute->mCtorArgs[1]);
isError = constant->mBool; isError = constant->mBool;
} }
}
}
BfError* error = NULL; BfError* error = NULL;
if (isError) if (isError)