diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index fa478ac6..6cb979ea 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -38,7 +38,7 @@ jobs: - name: Verify 3.9.13 run: python __tests__/verify-python.py 3.9.13 - - name: Run with setup-python 3.9.13 + - name: Run with setup-python 3.10.11 uses: ./ with: python-version: 3.10.11 @@ -89,7 +89,34 @@ jobs: python-version: '<3.13' - name: Verify <3.13 run: python __tests__/verify-python.py 3.12 + - name: Test Raw Endpoint Access run: | curl -L https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json | jq empty shell: bash + + verify-install-path: + name: Verify Install Path + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [windows-latest, windows-11-arm] + architecture: [x64, x86, arm64] + freethreaded: ['false', 'true'] + python-version: ['3.9', '3.10', '3.11', '3.12', '3.13.1'] + exclude: + - architecture: x64 + freethreaded: 'true' + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Set up Python + uses: ./ + with: + python-version: ${{ matrix.python-version }} + architecture: ${{ matrix.architecture }} + freethreaded: ${{ matrix.freethreaded }} + + - name: Verify Install Path + run: python __tests__/verify_windows_install_path.ps1 ${{ matrix.architecture }} ${{ matrix.freethreaded }} ${{ matrix.python-version }} diff --git a/__tests__/verify-windows-install-path.ps1 b/__tests__/verify-windows-install-path.ps1 new file mode 100644 index 00000000..9ee8eb36 --- /dev/null +++ b/__tests__/verify-windows-install-path.ps1 @@ -0,0 +1,43 @@ +import os +import sys + +def build_expected_path(architecture, freethreaded): + major = 3 + minor = 13 + version_suffix = f"{major}{minor}" + + if architecture == "x86" and (major > 3 or (major == 3 and minor >= 10)): + version_suffix += "-32" + elif architecture == "arm64": + version_suffix += "-arm64" + + if freethreaded == "true": + version_suffix += "t" + if architecture == "x86": + version_suffix += "-32" + elif architecture == "arm64": + version_suffix += "-arm64" + + base_path = os.getenv("APPDATA", "") + return os.path.join(base_path, "Python", f"Python{version_suffix}", "Scripts") + +def main(): + if len(sys.argv) != 3: + print("Usage: python verify_windows_install_path.py ") + sys.exit(1) + + architecture = sys.argv[1] + freethreaded = sys.argv[2] + + expected_path = build_expected_path(architecture, freethreaded) + print(f"Expected PATH entry: {expected_path}") + + path_env = os.getenv("PATH", "") + if expected_path.lower() not in path_env.lower(): + print("Expected path not found in PATH") + sys.exit(1) + else: + print("Correct path present in PATH") + +if __name__ == "__main__": + main() \ No newline at end of file diff --git a/dist/setup/index.js b/dist/setup/index.js index 4e3f2673..fd3d14a3 100644 --- a/dist/setup/index.js +++ b/dist/setup/index.js @@ -96164,13 +96164,32 @@ function useCpythonVersion(version, architecture, updateEnvironment, checkLatest core.addPath(installDir); core.addPath(_binDir); if (utils_1.IS_WINDOWS) { - // Add --user directory - // `installDir` from tool cache should look like $RUNNER_TOOL_CACHE/Python//x64/ - // So if `findLocalTool` succeeded above, we must have a conformant `installDir` + // Extract version details const version = path.basename(path.dirname(installDir)); const major = semver.major(version); const minor = semver.minor(version); - const userScriptsDir = path.join(process.env['APPDATA'] || '', 'Python', `Python${major}${minor}`, 'Scripts'); + const basePath = process.env['APPDATA'] || ''; + let versionSuffix = `${major}${minor}`; + // Append '-32' for x86 architecture if Python version is >= 3.10 + if (architecture === 'x86' && + (major > 3 || (major === 3 && minor >= 10))) { + versionSuffix += '-32'; + } + else if (architecture === 'arm64') { + versionSuffix += '-arm64'; + } + // Append 't' for freethreaded builds + if (freethreaded) { + versionSuffix += 't'; + if (architecture === 'x86-freethreaded') { + versionSuffix += '-32'; + } + else if (architecture === 'arm64-freethreaded') { + versionSuffix += '-arm64'; + } + } + // Add user Scripts path + const userScriptsDir = path.join(basePath, 'Python', `Python${versionSuffix}`, 'Scripts'); core.addPath(userScriptsDir); } // On Linux and macOS, pip will create the --user directory and add it to PATH as needed. diff --git a/src/find-python.ts b/src/find-python.ts index ddb027cb..2e317d9c 100644 --- a/src/find-python.ts +++ b/src/find-python.ts @@ -49,8 +49,8 @@ export async function useCpythonVersion( // Use the freethreaded version if it was specified in the input, e.g., 3.13t freethreaded = true; } - core.debug(`Semantic version spec of ${version} is ${semanticVersionSpec}`); + core.debug(`Semantic version spec of ${version} is ${semanticVersionSpec}`); if (freethreaded) { // Free threaded versions use an architecture suffix like `x64-freethreaded` core.debug(`Using freethreaded version of ${semanticVersionSpec}`); @@ -152,17 +152,36 @@ export async function useCpythonVersion( core.addPath(_binDir); if (IS_WINDOWS) { - // Add --user directory - // `installDir` from tool cache should look like $RUNNER_TOOL_CACHE/Python//x64/ - // So if `findLocalTool` succeeded above, we must have a conformant `installDir` + // Extract version details const version = path.basename(path.dirname(installDir)); const major = semver.major(version); const minor = semver.minor(version); + const basePath = process.env['APPDATA'] || ''; + let versionSuffix = `${major}${minor}`; + // Append '-32' for x86 architecture if Python version is >= 3.10 + if ( + architecture === 'x86' && + (major > 3 || (major === 3 && minor >= 10)) + ) { + versionSuffix += '-32'; + } else if (architecture === 'arm64') { + versionSuffix += '-arm64'; + } + // Append 't' for freethreaded builds + if (freethreaded) { + versionSuffix += 't'; + if (architecture === 'x86-freethreaded') { + versionSuffix += '-32'; + } else if (architecture === 'arm64-freethreaded') { + versionSuffix += '-arm64'; + } + } + // Add user Scripts path const userScriptsDir = path.join( - process.env['APPDATA'] || '', + basePath, 'Python', - `Python${major}${minor}`, + `Python${versionSuffix}`, 'Scripts' ); core.addPath(userScriptsDir);