From 86cdea3e7a0454171df0064569bc6c4678a8a67d Mon Sep 17 00:00:00 2001 From: Aparna Jyothi Date: Wed, 23 Oct 2024 15:35:45 +0530 Subject: [PATCH 1/3] Update error message for no dependencies to cache --- dist/cache-save/index.js | 2 +- src/cache-save.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dist/cache-save/index.js b/dist/cache-save/index.js index aa4501f9..2b22f4a7 100644 --- a/dist/cache-save/index.js +++ b/dist/cache-save/index.js @@ -81165,7 +81165,7 @@ function saveCache(packageManager) { const cachePaths = JSON.parse(cachePathState); core.debug(`paths for caching are ${cachePaths.join(', ')}`); if (!isCacheDirectoryExists(cachePaths)) { - throw new Error(`Cache folder path is retrieved for ${packageManager} but doesn't exist on disk: ${cachePaths.join(', ')}`); + throw new Error(`Cache folder path is retrieved for ${packageManager} but doesn't exist on disk: ${cachePaths.join(', ')}. This likely indicates that there are no dependencies to cache. Consider removing the cache step if it is not needed.`); } const primaryKey = core.getState(cache_distributor_1.State.STATE_CACHE_PRIMARY_KEY); const matchedKey = core.getState(cache_distributor_1.State.CACHE_MATCHED_KEY); diff --git a/src/cache-save.ts b/src/cache-save.ts index fbb481c1..4aec04e4 100644 --- a/src/cache-save.ts +++ b/src/cache-save.ts @@ -41,7 +41,7 @@ async function saveCache(packageManager: string) { throw new Error( `Cache folder path is retrieved for ${packageManager} but doesn't exist on disk: ${cachePaths.join( ', ' - )}` + )}. This likely indicates that there are no dependencies to cache. Consider removing the cache step if it is not needed.` ); } From 8fa7fa142d4bd1b8c86bd5d3b4120c487a65ce22 Mon Sep 17 00:00:00 2001 From: Aparna Jyothi Date: Wed, 29 Jan 2025 20:08:46 +0530 Subject: [PATCH 2/3] Remove ubuntu-20.04 --- .github/workflows/e2e-tests.yml | 1 - .github/workflows/test-graalpy.yml | 4 ++-- .github/workflows/test-pypy.yml | 4 ++-- .github/workflows/test-python.yml | 9 +-------- 4 files changed, 5 insertions(+), 13 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index c718b212..91419ee9 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -19,7 +19,6 @@ jobs: matrix: operating-system: [ - ubuntu-20.04, windows-latest, ubuntu-22.04, ubuntu-latest, diff --git a/.github/workflows/test-graalpy.yml b/.github/workflows/test-graalpy.yml index 9f01429e..c5eccdf3 100644 --- a/.github/workflows/test-graalpy.yml +++ b/.github/workflows/test-graalpy.yml @@ -18,7 +18,7 @@ jobs: strategy: fail-fast: false matrix: - os: [macos-latest, ubuntu-20.04, ubuntu-latest, macos-13] + os: [macos-latest, ubuntu-latest, macos-13] graalpy: - 'graalpy-22.3' - 'graalpy-23.0' @@ -65,7 +65,7 @@ jobs: strategy: fail-fast: false matrix: - os: [macos-latest, ubuntu-20.04, ubuntu-latest, macos-13] + os: [macos-latest, ubuntu-latest, macos-13] graalpy: ['graalpy22.3', 'graalpy23.0', 'graalpy23.1', 'graalpy24.1'] steps: diff --git a/.github/workflows/test-pypy.yml b/.github/workflows/test-pypy.yml index 716f7501..05db90fb 100644 --- a/.github/workflows/test-pypy.yml +++ b/.github/workflows/test-pypy.yml @@ -21,7 +21,7 @@ jobs: fail-fast: false matrix: os: - [macos-latest, windows-latest, ubuntu-20.04, ubuntu-latest, macos-13] + [macos-latest, windows-latest, ubuntu-latest, macos-13] pypy: - 'pypy-2.7' - 'pypy-3.10' @@ -76,7 +76,7 @@ jobs: fail-fast: false matrix: os: - [macos-latest, windows-latest, ubuntu-20.04, ubuntu-latest, macos-13] + [macos-latest, windows-latest, ubuntu-latest, macos-13] pypy: ['pypy2.7', 'pypy3.9', 'pypy3.10-nightly'] steps: diff --git a/.github/workflows/test-python.yml b/.github/workflows/test-python.yml index ebb5bf05..3861c462 100644 --- a/.github/workflows/test-python.yml +++ b/.github/workflows/test-python.yml @@ -24,7 +24,6 @@ jobs: [ macos-latest, windows-latest, - ubuntu-20.04, ubuntu-22.04, macos-13, ubuntu-latest @@ -67,7 +66,6 @@ jobs: [ macos-latest, windows-latest, - ubuntu-20.04, ubuntu-22.04, macos-13, ubuntu-latest @@ -113,7 +111,6 @@ jobs: [ macos-latest, windows-latest, - ubuntu-20.04, ubuntu-22.04, macos-13, ubuntu-latest @@ -157,7 +154,6 @@ jobs: [ macos-latest, windows-latest, - ubuntu-20.04, ubuntu-22.04, macos-13, ubuntu-latest @@ -206,7 +202,6 @@ jobs: [ macos-latest, windows-latest, - ubuntu-20.04, ubuntu-22.04, macos-13, ubuntu-latest @@ -254,8 +249,7 @@ jobs: os: [ macos-latest, - windows-latest, - ubuntu-20.04, + windows-latest, ubuntu-22.04, macos-13, ubuntu-latest @@ -354,7 +348,6 @@ jobs: [ macos-latest, windows-latest, - ubuntu-20.04, ubuntu-22.04, macos-13, ubuntu-latest From c3577e1427a31d67e4127e2d77d99295d3775fd3 Mon Sep 17 00:00:00 2001 From: Aparna Jyothi Date: Wed, 29 Jan 2025 20:17:46 +0530 Subject: [PATCH 3/3] npm run format-check --- .github/workflows/e2e-tests.yml | 8 +---- .github/workflows/test-pypy.yml | 6 ++-- .github/workflows/test-python.yml | 56 ++++--------------------------- 3 files changed, 10 insertions(+), 60 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 91419ee9..d67bf4cc 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -18,13 +18,7 @@ jobs: strategy: matrix: operating-system: - [ - windows-latest, - ubuntu-22.04, - ubuntu-latest, - macos-latest, - macos-13 - ] + [windows-latest, ubuntu-22.04, ubuntu-latest, macos-latest, macos-13] steps: - name: Checkout uses: actions/checkout@v4 diff --git a/.github/workflows/test-pypy.yml b/.github/workflows/test-pypy.yml index 05db90fb..702c0e92 100644 --- a/.github/workflows/test-pypy.yml +++ b/.github/workflows/test-pypy.yml @@ -20,8 +20,7 @@ jobs: strategy: fail-fast: false matrix: - os: - [macos-latest, windows-latest, ubuntu-latest, macos-13] + os: [macos-latest, windows-latest, ubuntu-latest, macos-13] pypy: - 'pypy-2.7' - 'pypy-3.10' @@ -75,8 +74,7 @@ jobs: strategy: fail-fast: false matrix: - os: - [macos-latest, windows-latest, ubuntu-latest, macos-13] + os: [macos-latest, windows-latest, ubuntu-latest, macos-13] pypy: ['pypy2.7', 'pypy3.9', 'pypy3.10-nightly'] steps: diff --git a/.github/workflows/test-python.yml b/.github/workflows/test-python.yml index 3861c462..6babd2dd 100644 --- a/.github/workflows/test-python.yml +++ b/.github/workflows/test-python.yml @@ -21,13 +21,7 @@ jobs: fail-fast: false matrix: os: - [ - macos-latest, - windows-latest, - ubuntu-22.04, - macos-13, - ubuntu-latest - ] + [macos-latest, windows-latest, ubuntu-22.04, macos-13, ubuntu-latest] python: [3.9.13, 3.10.11, 3.11.9, 3.12.3, 3.13.0] steps: - name: Checkout @@ -63,13 +57,7 @@ jobs: fail-fast: false matrix: os: - [ - macos-latest, - windows-latest, - ubuntu-22.04, - macos-13, - ubuntu-latest - ] + [macos-latest, windows-latest, ubuntu-22.04, macos-13, ubuntu-latest] python: [3.9.13, 3.10.11, 3.11.9, 3.12.3, 3.13.0] steps: - name: Checkout @@ -108,13 +96,7 @@ jobs: fail-fast: false matrix: os: - [ - macos-latest, - windows-latest, - ubuntu-22.04, - macos-13, - ubuntu-latest - ] + [macos-latest, windows-latest, ubuntu-22.04, macos-13, ubuntu-latest] python: [3.9.13, 3.10.11, 3.11.9, 3.12.3, 3.13.0] steps: - name: Checkout @@ -151,13 +133,7 @@ jobs: fail-fast: false matrix: os: - [ - macos-latest, - windows-latest, - ubuntu-22.04, - macos-13, - ubuntu-latest - ] + [macos-latest, windows-latest, ubuntu-22.04, macos-13, ubuntu-latest] python: [3.9.13, 3.10.11, 3.11.9, '==3.12.3', 3.13.0] steps: - name: Checkout @@ -199,13 +175,7 @@ jobs: fail-fast: false matrix: os: - [ - macos-latest, - windows-latest, - ubuntu-22.04, - macos-13, - ubuntu-latest - ] + [macos-latest, windows-latest, ubuntu-22.04, macos-13, ubuntu-latest] python: [3.9.13, 3.10.11, 3.11.9, 3.12.3, 3.13.0] steps: - name: Checkout @@ -247,13 +217,7 @@ jobs: fail-fast: false matrix: os: - [ - macos-latest, - windows-latest, - ubuntu-22.04, - macos-13, - ubuntu-latest - ] + [macos-latest, windows-latest, ubuntu-22.04, macos-13, ubuntu-latest] steps: - name: Checkout uses: actions/checkout@v4 @@ -345,13 +309,7 @@ jobs: fail-fast: false matrix: os: - [ - macos-latest, - windows-latest, - ubuntu-22.04, - macos-13, - ubuntu-latest - ] + [macos-latest, windows-latest, ubuntu-22.04, macos-13, ubuntu-latest] python: ['3.9', '3.10', '3.11', '3.12', '3.13'] steps: - name: Checkout