From ff2affb733823cde8be1226557d0872e84b08e68 Mon Sep 17 00:00:00 2001 From: Brian Fiete Date: Fri, 18 Oct 2024 13:01:43 -0400 Subject: [PATCH] Fixed handle leak in BfpProcess_GetById --- BeefTools/BeefCon/src/Program.bf | 1 + BeefySysLib/platform/win/Platform.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/BeefTools/BeefCon/src/Program.bf b/BeefTools/BeefCon/src/Program.bf index 147c2062..e1a6d909 100644 --- a/BeefTools/BeefCon/src/Program.bf +++ b/BeefTools/BeefCon/src/Program.bf @@ -163,6 +163,7 @@ class Program while (true) { // Check BeefIDE process + if ((mPid != 123) || (!Debug.IsDebuggerPresent)) { var process = Platform.BfpProcess_GetById(null, mPid, null); if (process == null) diff --git a/BeefySysLib/platform/win/Platform.cpp b/BeefySysLib/platform/win/Platform.cpp index 39dcce87..bee070f6 100644 --- a/BeefySysLib/platform/win/Platform.cpp +++ b/BeefySysLib/platform/win/Platform.cpp @@ -1301,6 +1301,7 @@ BFP_EXPORT BfpProcess* BFP_CALLTYPE BfpProcess_GetById(const char* machineName, OUTRESULT(BfpProcessResult_NotFound); return NULL; } + ::CloseHandle(hProc); BfpProcess* process = new BfpProcess(); process->mProcessId = processId;