From bc717c7dcb2ebe04bc3f639ca78103e6fe34ef8e Mon Sep 17 00:00:00 2001 From: Brian Fiete Date: Sun, 22 Sep 2019 09:34:07 -0700 Subject: [PATCH] Put back symbol lookup --- BeefySysLib/platform/win/CrashCatcher.cpp | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/BeefySysLib/platform/win/CrashCatcher.cpp b/BeefySysLib/platform/win/CrashCatcher.cpp index aca73972..45869a40 100644 --- a/BeefySysLib/platform/win/CrashCatcher.cpp +++ b/BeefySysLib/platform/win/CrashCatcher.cpp @@ -666,10 +666,7 @@ static String ImageHelpWalk(PCONTEXT theContext, int theSkipCount) HANDLE hProcess = GetCurrentProcess(); - bool forceFail = true; - - - + bool forceFail = false; if ((gSymGetSymFromAddr(hProcess, sf.AddrPC.Offset, &symDisplacement, pSymbol)) && (!forceFail)) { char aUDName[256]; @@ -712,11 +709,11 @@ static String ImageHelpWalk(PCONTEXT theContext, int theSkipCount) GetLogicalAddress((PVOID)sf.AddrPC.Offset, szModule, sizeof(szModule), section, offset); - ModuleInfo* moduleInfo = NULL; - if (moduleInfoMap.TryAdd(szModule, NULL, &moduleInfo)) - { - - } +// ModuleInfo* moduleInfo = NULL; +// if (moduleInfoMap.TryAdd(szModule, NULL, &moduleInfo)) +// { +// +// } aDebugDump += StrFormat("%@ %@ %04X:%@ %s\r\n", sf.AddrFrame.Offset, sf.AddrPC.Offset, section, offset, GetFileName(szModule).c_str()); } @@ -856,7 +853,7 @@ static void DoHandleDebugEvent(LPEXCEPTION_POINTERS lpEP) if (CreateMiniDump(lpEP, crashPath)) { - aDebugDump += StrFormat("Crash minidump saved as '%s'\n", crashPath.c_str()); + aDebugDump += StrFormat("Crash minidump saved as %s\n", crashPath.c_str()); } }