From a2f5517e5c8ff19c845e33a7d0c8febfa3d0d69a Mon Sep 17 00:00:00 2001 From: Brian Fiete Date: Thu, 22 Feb 2024 06:52:31 -0500 Subject: [PATCH] AddPhiIncoming valueless fix --- IDEHelper/Compiler/BfExprEvaluator.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/IDEHelper/Compiler/BfExprEvaluator.cpp b/IDEHelper/Compiler/BfExprEvaluator.cpp index 5e7b9826..2e5c50a4 100644 --- a/IDEHelper/Compiler/BfExprEvaluator.cpp +++ b/IDEHelper/Compiler/BfExprEvaluator.cpp @@ -23235,8 +23235,10 @@ bool BfExprEvaluator::PerformBinaryOperation_NullCoalesce(BfTokenNode* opToken, else { auto phi = mModule->mBfIRBuilder->CreatePhi(mModule->mBfIRBuilder->MapType(leftValue.mType), 2); - mModule->mBfIRBuilder->AddPhiIncoming(phi, leftValue.mValue, endLhsBB); - mModule->mBfIRBuilder->AddPhiIncoming(phi, rightValue.mValue, endRhsBB); + if (!leftValue.mType->IsValuelessType()) + mModule->mBfIRBuilder->AddPhiIncoming(phi, leftValue.mValue, endLhsBB); + if (!rightValue.mType->IsValuelessType()) + mModule->mBfIRBuilder->AddPhiIncoming(phi, rightValue.mValue, endRhsBB); mResult = BfTypedValue(phi, leftValue.mType); }