From 7b65f8887e080b9f807e37a69f799ac6de8909f6 Mon Sep 17 00:00:00 2001 From: Brian Fiete Date: Thu, 16 Dec 2021 08:00:20 -0500 Subject: [PATCH] Fixed autocomplete stack overflow --- IDE/src/Compiler/BfCompiler.bf | 4 ++-- IDEHelper/Compiler/BfSystem.cpp | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/IDE/src/Compiler/BfCompiler.bf b/IDE/src/Compiler/BfCompiler.bf index d391831a..efc60b19 100644 --- a/IDE/src/Compiler/BfCompiler.bf +++ b/IDE/src/Compiler/BfCompiler.bf @@ -243,13 +243,13 @@ namespace IDE.Compiler public void GetAutocompleteInfo(String outAutocompleteInfo) { char8* result = BfCompiler_GetAutocompleteInfo(mNativeBfCompiler); - scope String(result).MoveTo(outAutocompleteInfo); + outAutocompleteInfo.Append(StringView(result)); } public void GetSymbolReferences(BfPassInstance passInstance, BfResolvePassData resolvePassData, String outSymbolReferences) { char8* result = BfCompiler_GetSymbolReferences(mNativeBfCompiler, passInstance.mNativeBfPassInstance, resolvePassData.mNativeResolvePassData); - scope String(result).MoveTo(outSymbolReferences); + outSymbolReferences.Append(StringView(result)); } /*public void UpdateRenameSymbols(BfPassInstance passInstance, BfResolvePassData resolvePassData) diff --git a/IDEHelper/Compiler/BfSystem.cpp b/IDEHelper/Compiler/BfSystem.cpp index 78f16b8f..de407542 100644 --- a/IDEHelper/Compiler/BfSystem.cpp +++ b/IDEHelper/Compiler/BfSystem.cpp @@ -3763,6 +3763,7 @@ void BfSystem::RemoveOldData() void BfSystem::VerifyTypeDef(BfTypeDef* typeDef) { +#if defined _DEBUG && false auto _FindTypeDef = [&](BfTypeReference* typeRef) { if (auto directStrTypeRef = BfNodeDynCast(typeRef)) @@ -3796,6 +3797,7 @@ void BfSystem::VerifyTypeDef(BfTypeDef* typeDef) _FindTypeDef(paramDef->mTypeRef); } } +#endif } BfTypeOptions* BfSystem::GetTypeOptions(int optionsIdx)