From 41185e871c9475fcdc9d16bfbb97a9ed8a3c42ed Mon Sep 17 00:00:00 2001 From: Brian Fiete Date: Fri, 20 Sep 2019 10:40:09 -0700 Subject: [PATCH] Fixed minidump --- IDE/src/IDEApp.bf | 6 +++--- IDEHelper/COFF.cpp | 6 +++--- IDEHelper/WinDebugger.cpp | 1 + 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/IDE/src/IDEApp.bf b/IDE/src/IDEApp.bf index b604dc44..f7a36914 100644 --- a/IDE/src/IDEApp.bf +++ b/IDE/src/IDEApp.bf @@ -875,12 +875,12 @@ namespace IDE public void DoOpenCrashDump() { #if !CLI - /*if (mDeferredOpenFileName != null) + if (mDeferredOpenFileName != null) { - + OpenCrashDump(mDeferredOpenFileName); DeleteAndNullify!(mDeferredOpenFileName); return; - }*/ + } var fileDialog = scope OpenFileDialog(); fileDialog.Title = "Open Crash Dump"; diff --git a/IDEHelper/COFF.cpp b/IDEHelper/COFF.cpp index 36c501bf..ad5263d6 100644 --- a/IDEHelper/COFF.cpp +++ b/IDEHelper/COFF.cpp @@ -6328,9 +6328,9 @@ String COFF::GetOldSourceCommand(const StringImpl& path) if (!matches) break; - String& target = defs["SRCSRVTRG"]; - String& cmd = defs["SRCSRVCMD"]; - String& env = defs["SRCSRVENV"]; + String target = defs["SRCSRVTRG"]; + String cmd = defs["SRCSRVCMD"]; + String env = defs["SRCSRVENV"]; _Expand(target); _Expand(cmd); diff --git a/IDEHelper/WinDebugger.cpp b/IDEHelper/WinDebugger.cpp index bfe9e736..016f3300 100644 --- a/IDEHelper/WinDebugger.cpp +++ b/IDEHelper/WinDebugger.cpp @@ -1417,6 +1417,7 @@ bool WinDebugger::DoUpdate() Array pendingList; for (auto kv : mPendingDebugInfoLoad) pendingList.Add(kv.mValue); + mPendingDebugInfoLoad.Clear(); for (auto& entry : pendingList) {