From c6b2aa4b27e1b8a5b5d61139ec32d198239a6af8 Mon Sep 17 00:00:00 2001 From: Jannis Date: Fri, 12 Apr 2024 10:08:47 +0000 Subject: [PATCH 1/2] Update Thread.bf --- BeefLibs/corlib/src/Threading/Thread.bf | 28 +++++++++++++++++-------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/BeefLibs/corlib/src/Threading/Thread.bf b/BeefLibs/corlib/src/Threading/Thread.bf index 3d3861b5..f716d895 100644 --- a/BeefLibs/corlib/src/Threading/Thread.bf +++ b/BeefLibs/corlib/src/Threading/Thread.bf @@ -19,7 +19,7 @@ namespace System.Threading private Object mThreadStartArg; - bool mAutoDelete; + bool mAutoDelete = true; bool mJoinOnDelete; static Monitor sMonitor = new .() ~ delete _; @@ -239,21 +239,31 @@ namespace System.Threading } } + public void Start() + { + StartInternal(); + } + public void Start(bool autoDelete = true) { - mAutoDelete = autoDelete; - StartInternal(); + mAutoDelete = autoDelete; + Start(); } + + public void Start(Object parameter) + { + if (mDelegate is ThreadStart) + { + Runtime.FatalError(); + } + mThreadStartArg = parameter; + StartInternal(); + } public void Start(Object parameter, bool autoDelete = true) { mAutoDelete = autoDelete; - if (mDelegate is ThreadStart) - { - Runtime.FatalError(); - } - mThreadStartArg = parameter; - StartInternal(); + Start(parameter); } #if BF_PLATFORM_WINDOWS && !BF_RUNTIME_DISABLE From 14f57af2b37f5fedf425d13d169fcf67216280a6 Mon Sep 17 00:00:00 2001 From: Jannis Date: Fri, 12 Apr 2024 10:14:38 +0000 Subject: [PATCH 2/2] Update Thread.bf removed optionality from parameters --- BeefLibs/corlib/src/Threading/Thread.bf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BeefLibs/corlib/src/Threading/Thread.bf b/BeefLibs/corlib/src/Threading/Thread.bf index f716d895..bcd1c318 100644 --- a/BeefLibs/corlib/src/Threading/Thread.bf +++ b/BeefLibs/corlib/src/Threading/Thread.bf @@ -244,7 +244,7 @@ namespace System.Threading StartInternal(); } - public void Start(bool autoDelete = true) + public void Start(bool autoDelete) { mAutoDelete = autoDelete; Start(); @@ -260,7 +260,7 @@ namespace System.Threading StartInternal(); } - public void Start(Object parameter, bool autoDelete = true) + public void Start(Object parameter, bool autoDelete) { mAutoDelete = autoDelete; Start(parameter);